test: add OpenSSL 3.0 checks #37860
Closed
test: add OpenSSL 3.0 checks #37860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Currently test-crypto-keygen.js fails when dynamically linking against OpenSSL 3.0 which the following error: === debug test-crypto-keygen === Path: parallel/test-crypto-keygen node:assert:901 throw newErr; ^ AssertionError [ERR_ASSERTION]: ifError got unwanted exception: error:05000072:dsa routines::bad ffc parameters at DsaKeyPairGenJob.<anonymous> (/nodejs/openssl/test/common/index.js:342:12) at DsaKeyPairGenJob.<anonymous> (/openssl/test/common/index.js:379:15) at DsaKeyPairGenJob.job.ondone (node:internal/crypto/keygen:77:23) { generatedMessage: false, code: 'ERR_ASSERTION', actual: [Error: error:05000072:dsa routines::bad ffc parameters], expected: null, operator: 'ifError' } Command: node /nodejs/openssl/test/parallel/test-crypto-keygen.js This commit adds a check and adjusts the modulus length when linking against OpenSSL 3.0. 
nodejs-github-bot added needs-ci 
Collaborator
jasnell approved these changes Mar 22, 2021
Collaborator
targos approved these changes Mar 22, 2021
richardlau approved these changes Mar 22, 2021
BethGriggs approved these changes Mar 22, 2021
aduh95 added the author ready 
cjihrig approved these changes Mar 23, 2021
lpinca approved these changes Mar 23, 2021
addaleax approved these changes Mar 23, 2021
danbev added a commit that referenced this pull request Mar 24, 2021
Currently test-crypto-keygen.js fails when dynamically linking against OpenSSL 3.0 which the following error: === debug test-crypto-keygen === Path: parallel/test-crypto-keygen node:assert:901 throw newErr; ^ AssertionError [ERR_ASSERTION]: ifError got unwanted exception: error:05000072:dsa routines::bad ffc parameters at DsaKeyPairGenJob.<anonymous> (/nodejs/openssl/test/common/index.js:342:12) at DsaKeyPairGenJob.<anonymous> (/openssl/test/common/index.js:379:15) at DsaKeyPairGenJob.job.ondone (node:internal/crypto/keygen:77:23) { generatedMessage: false, code: 'ERR_ASSERTION', actual: [Error: error:05000072:dsa routines::bad ffc parameters], expected: null, operator: 'ifError' } Command: node /nodejs/openssl/test/parallel/test-crypto-keygen.js This commit adds a check and adjusts the modulus length when linking against OpenSSL 3.0. PR-URL: #37860 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> danbev added a commit that referenced this pull request Mar 24, 2021
PR-URL: #37860 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Contributor Author
ruyadorno pushed a commit that referenced this pull request Mar 29, 2021
Currently test-crypto-keygen.js fails when dynamically linking against OpenSSL 3.0 which the following error: === debug test-crypto-keygen === Path: parallel/test-crypto-keygen node:assert:901 throw newErr; ^ AssertionError [ERR_ASSERTION]: ifError got unwanted exception: error:05000072:dsa routines::bad ffc parameters at DsaKeyPairGenJob.<anonymous> (/nodejs/openssl/test/common/index.js:342:12) at DsaKeyPairGenJob.<anonymous> (/openssl/test/common/index.js:379:15) at DsaKeyPairGenJob.job.ondone (node:internal/crypto/keygen:77:23) { generatedMessage: false, code: 'ERR_ASSERTION', actual: [Error: error:05000072:dsa routines::bad ffc parameters], expected: null, operator: 'ifError' } Command: node /nodejs/openssl/test/parallel/test-crypto-keygen.js This commit adds a check and adjusts the modulus length when linking against OpenSSL 3.0. PR-URL: #37860 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> ruyadorno pushed a commit that referenced this pull request Mar 29, 2021
PR-URL: #37860 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
ruyadorno pushed a commit that referenced this pull request Mar 30, 2021
Currently test-crypto-keygen.js fails when dynamically linking against OpenSSL 3.0 which the following error: === debug test-crypto-keygen === Path: parallel/test-crypto-keygen node:assert:901 throw newErr; ^ AssertionError [ERR_ASSERTION]: ifError got unwanted exception: error:05000072:dsa routines::bad ffc parameters at DsaKeyPairGenJob.<anonymous> (/nodejs/openssl/test/common/index.js:342:12) at DsaKeyPairGenJob.<anonymous> (/openssl/test/common/index.js:379:15) at DsaKeyPairGenJob.job.ondone (node:internal/crypto/keygen:77:23) { generatedMessage: false, code: 'ERR_ASSERTION', actual: [Error: error:05000072:dsa routines::bad ffc parameters], expected: null, operator: 'ifError' } Command: node /nodejs/openssl/test/parallel/test-crypto-keygen.js This commit adds a check and adjusts the modulus length when linking against OpenSSL 3.0. PR-URL: #37860 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> ruyadorno pushed a commit that referenced this pull request Mar 30, 2021
PR-URL: #37860 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
These commits add OpenSSL 3.0 checks to test-crypto-keygen.js and test-tls-passphase.js.
There is currently a build request to add a CI job so hopefully these failures will be reported automatically in the near future.