test: increase timeout on ASAN Action #37007
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Setting the timeout to 300s (or 5 minutes) instead of the default 120s per test to limit the number of false negative on GH Action CI results.
nodejs-github-bot added the meta 
ttzztztz approved these changes Jan 23, 2021
Contributor
ttzztztz left a comment
ttzztztz left a comment There was a problem hiding this comment.
This is a nice improvement
Trott reviewed Jan 24, 2021
Trott approved these changes Jan 24, 2021
aduh95 added the author ready 
Collaborator
jasnell approved these changes Jan 24, 2021
jasnell pushed a commit that referenced this pull request Jan 24, 2021
Setting the timeout to 300s (or 5 minutes) instead of the default 120s per test to limit the number of false negative on GH Action CI results. PR-URL: #37007 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
| Landed in 90cae3a |
targos pushed a commit that referenced this pull request Feb 2, 2021
Setting the timeout to 300s (or 5 minutes) instead of the default 120s per test to limit the number of false negative on GH Action CI results. PR-URL: #37007 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request May 25, 2021
Setting the timeout to 300s (or 5 minutes) instead of the default 120s per test to limit the number of false negative on GH Action CI results. PR-URL: #37007 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request May 30, 2021
Setting the timeout to 300s (or 5 minutes) instead of the default 120s per test to limit the number of false negative on GH Action CI results. PR-URL: #37007 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
Setting the timeout to 300s (or 5 minutes) instead of the default 120s per test to limit the number of false negative on GH Action CI results. PR-URL: #37007 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jun 11, 2021
Setting the timeout to 300s (or 5 minutes) instead of the default 120s per test to limit the number of false negative on GH Action CI results. PR-URL: #37007 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Setting the timeout to 300s (or 5 minutes) instead of the default 120s per test to limit the number of false negative on GH Action CI results.