Skip to content

Conversation

@richardlau
Copy link
Member

Reflect the current status of support for building on arm64 (Apple Silicon/M1) based macOS.

Refs: nodejs/build#2474

cc @nodejs/platform-macos

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Nov 20, 2020
@richardlau richardlau added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. macos Issues and PRs related to the macOS platform / OSX. labels Nov 20, 2020
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Trott pushed a commit that referenced this pull request Nov 22, 2020
PR-URL: #36189 Refs: nodejs/build#2474 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ash Cripps <acripps@redhat.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@Trott
Copy link
Member

Trott commented Nov 22, 2020

Landed in 62a5626

@Trott Trott closed this Nov 22, 2020
@richardlau richardlau deleted the building branch November 22, 2020 16:16
codebytere pushed a commit that referenced this pull request Nov 22, 2020
PR-URL: #36189 Refs: nodejs/build#2474 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ash Cripps <acripps@redhat.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Pranshu Srivastava <rexagod@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@codebytere codebytere mentioned this pull request Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. macos Issues and PRs related to the macOS platform / OSX.

9 participants