Skip to content

Conversation

@cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Oct 9, 2020

Update ESLint to 7.11.0

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Update ESLint to 7.11.0
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 9, 2020
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamp LGTM

@cjihrig cjihrig added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 10, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 10, 2020

@cjihrig cjihrig added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 11, 2020
Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@cjihrig cjihrig added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 11, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 11, 2020
@github-actions
Copy link
Contributor

Landed in 2e4930b...2d83e74

@github-actions github-actions bot closed this Oct 11, 2020
nodejs-github-bot pushed a commit that referenced this pull request Oct 11, 2020
Update ESLint to 7.11.0 PR-URL: #35578 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@cjihrig cjihrig deleted the eslint branch October 11, 2020 23:42
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
Update ESLint to 7.11.0 PR-URL: nodejs#35578 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos added dont-land-on-v14.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-requested-v14.x labels Apr 30, 2021
targos pushed a commit that referenced this pull request May 16, 2021
Update ESLint to 7.11.0 PR-URL: #35578 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Jun 11, 2021
Update ESLint to 7.11.0 PR-URL: #35578 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tools Issues and PRs related to the tools directory.

7 participants