src: fix compiler warning in env.cc #35547
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
../src/env.cc:1227:22: error: lambda capture 'this' is not used [-Werror,-Wunused-lambda-capture] ForEachBaseObject([this](BaseObject* obj) { ^~~~ 
addaleax added fast-track 
nodejs-github-bot added the c++ 
cjihrig approved these changes Oct 7, 2020
github-actions bot removed the request-ci 
Collaborator
codebytere approved these changes Oct 7, 2020
devsnek approved these changes Oct 7, 2020
gireeshpunathil approved these changes Oct 8, 2020
gengjiawen approved these changes Oct 8, 2020
github-actions bot removed the request-ci Collaborator
2 tasks
Member
| Landed in ee5f849 |
gengjiawen pushed a commit that referenced this pull request Oct 8, 2020
../src/env.cc:1227:22: error: lambda capture 'this' is not used [-Werror,-Wunused-lambda-capture] ForEachBaseObject([this](BaseObject* obj) { ^~~~ PR-URL: #35547 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> 
Member
| This should land on v14.x when #35490 lands |
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
../src/env.cc:1227:22: error: lambda capture 'this' is not used [-Werror,-Wunused-lambda-capture] ForEachBaseObject([this](BaseObject* obj) { ^~~~ PR-URL: nodejs#35547 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> addaleax added a commit to addaleax/node that referenced this pull request May 23, 2021
../src/env.cc:1227:22: error: lambda capture 'this' is not used [-Werror,-Wunused-lambda-capture] ForEachBaseObject([this](BaseObject* obj) { ^~~~ PR-URL: nodejs#35547 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> targos pushed a commit that referenced this pull request May 25, 2021
../src/env.cc:1227:22: error: lambda capture 'this' is not used [-Werror,-Wunused-lambda-capture] ForEachBaseObject([this](BaseObject* obj) { ^~~~ PR-URL: #35547 Backport-PR-URL: #38786 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> 
targos pushed a commit that referenced this pull request Jun 11, 2021
../src/env.cc:1227:22: error: lambda capture 'this' is not used [-Werror,-Wunused-lambda-capture] ForEachBaseObject([this](BaseObject* obj) { ^~~~ PR-URL: #35547 Backport-PR-URL: #38786 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> 
This was referenced Sep 13, 2022
This was referenced Sep 29, 2022
This was referenced Oct 5, 2022
This was referenced Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
(I don’t think we need to discuss fast-tracking here, but you can feel free to 👍 this either way.)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes