modules: add setter for module.parent

[aduh95]

module.parent breaks the ecosystem when read-only (see #32217 (comment)). This PR adds a setter to allow user to change its value instead of throwing.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[nodejs-github-bot]

Review requested:

• @nodejs/modules

[richardlau]

CITGM: https://ci.nodejs.org/job/citgm-smoker/2498/

[bmeck]

LGTM pending lint

[richardlau]

From the CITGM results that have completed this has fixed the node-gyp test suite, thanks.

[richardlau]

Can we fast track? Would be good to get this in the next 14.x release

14.x isn't affected. #33533 didn't backport the breaking parts of #32217.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/33430/

[aduh95]

BTW, this should have the label dont-land-on-v14.x and dont-land-on-v12.x.

[ExE-Boss]

My only issue with converting module.parent into an accessor on the prototype is that delete module.parent no longer works (unless module is converted into a Proxy) and module.parent = undefined triggers the deprecation warning.

[bmeck]

Make delete work:

Suggested change

	) : setModuleParent,
	) : setModuleParent,
	configurable: true,

[bmeck]

@ExE-Boss making the property configurable should make delete work.

[bmeck]

Suggested change

	module.parent = undefined;
	module.parent = undefined;
	delete module.parent;
	assert.strictEqual('parent' in module, false);

[bmeck]

Suggested change

	const common = require('../common');
	const common = require('../common');
	const assert = require('assert');

[bmeck]

moving this to be on the module itself is needed to make delete work

[aduh95]

Wouldn't that trigger a new deprecation warning for each Module instance?

module.parent; // triggers one warning module.parent?.parent; // triggers another warning?

[ExE-Boss]

No, because the deprecation uses a deprecation code:

node/lib/internal/util.js

Lines 77 to 82 in ce84bac

	if (code !== undefined) {
	if (!codesWarned.has(code)) {
	process.emitWarning(msg, 'DeprecationWarning', code, deprecated);
	codesWarned.add(code);
	}
	} else {

[aduh95]

@ExE-Boss Would it be fine for you if we land this PR as is, and then someone else (maybe you?) opens another PR with the changes you're suggesting? I'm afraid I don't have the bandwidth to work on this currently, and I wouldn't want it to miss the v15.x release.

[ExE-Boss]

@aduh95 I don’t mind either way.

[aduh95]

Landed in aaf225a