v10.17.0 proposal #29875
Merged
v10.17.0 proposal #29875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Implements `napi_create_date()` as well as `napi_is_date()` to allow working with JavaScript Date objects. Backport-PR-URL: #28298 PR-URL: #25917 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Minor cleanup in the lifetime for the platform worker initialization synchronization barrier. PR-URL: #23419 Backport-PR-URL: #28844 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Do not crash when the session is no longer available. Fixes: #29457 PR-URL: #29459 Backport-PR-URL: #29619 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Don’t start reading more input data if we’re still busy writing output. This was overlooked in 8a4a193. Fixes: #29353 Fixes: #29393 PR-URL: #29399 Backport-PR-URL: #29619 Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
It is not needed, and causes an unnecessary runtime dependency with some linkers, such as devtoolset-6 on centos7-ppc64le. See: #29718 PR-URL: #29729 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com>
Correct docs to clarify that behaviour, and fix a race condition in test-http2-large-write-destroy.js. Fixes: #27863 Backport-PR-URL: #28904 PR-URL: #27891 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
TLSWrap::DoWrite() now concatenates data chunks and makes a single call to SSL_write(). Grouping data into a single segment: - reduces network overhead: by factors of even 2 or 3 in usages like `http2` or `form-data` - improves security: segment lengths can reveal lots of info, i.e. with `form-data`, how many fields are sent and the approximate length of every individual field and its headers - reduces encryption overhead: a quick benchmark showed a ~30% CPU time decrease for an extreme case, see #27573 (comment) Fixes: #27573 Backport-PR-URL: #28904 PR-URL: #27861 Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
When CMD is used to launch a process and CMD is killed too quickly, the process can stay behind running in suspended state, never completing. This only happens in Windows Server 2008R2. Refs: nodejs/build#1829 PR-URL: #28723 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
nodejs-github-bot added lib / src 
Member Author
| Draft release - at the moment I'm just pulling in the open backport PRs and the items that are tagged |
Member Author
richardlau reviewed Oct 7, 2019
Member
Collaborator
Member
| @BethGriggs is it planned to also include all current open manual backports? (https://github.com/nodejs/node/pulls?q=is%3Aopen+is%3Apr+label%3Av10.x) |
This adds a flag to define the default behavior for unhandled rejections. Three modes exist: `none`, `warn` and `strict`. The first is going to silence all unhandled rejection warnings. The second behaves identical to the current default with the excetion that no deprecation warning will be printed and the last is going to throw an error for each unhandled rejection, just as regular exceptions do. It is possible to intercept those with the `uncaughtException` hook as with all other exceptions as well. This PR has no influence on the existing `unhandledRejection` hook. If that is used, it will continue to function as before. PR-URL: #26599 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This adds a missing return value for the worker specific fatal exception handler. PR-URL: #29036 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
BethGriggs force-pushed the v10.17.0-proposal branch from c3e596f to ae884d3 Compare This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Collaborator
| CI: https://ci.nodejs.org/job/node-test-pull-request/26135/ ✅ (Known Alpine failures) |
Member Author
richardlau approved these changes Oct 21, 2019
Member Author
| CITGM looks ok mostly familiar flakes - React should have been skipped on IBM platforms (resolved by nodejs/citgm#754) |
BridgeAR reviewed Oct 22, 2019
Collaborator
BethGriggs force-pushed the v10.17.0-proposal branch from ae884d3 to 864c7ff Compare Member Author
| @BridgeAR updated PTAL, thanks! |
tniessen approved these changes Oct 22, 2019
BethGriggs force-pushed the v10.17.0-proposal branch from 864c7ff to 0dc0160 Compare Notable changes: * crypto: * add support for chacha20-poly1305 for AEAD (chux0519) #24081 * increase maxmem range from 32 to 53 bits (Tobias Nießen) #28799 * deps: * update npm to 6.11.3 (claudiahdz) #29430 * upgrade openssl sources to 1.1.1d (Sam Roberts) #29921 * dns: * remove dns.promises experimental warning (cjihrig) #26592 * fs: * remove experimental warning for fs.promises (Anna Henningsen) #26581 * http: * makes response.writeHead return the response (Mark S. Everitt) #25974 * http2: * makes response.writeHead return the response (Mark S. Everitt) #25974 * n-api: * make func argument of napi\_create\_threadsafe\_function optional (legendecas) #27791 * mark version 5 N-APIs as stable (Gabriel Schulhof) #29401 * implement date object (Jarrod Connolly) #25917 * process: * add --unhandled-rejections flag (Ruben Bridgewater) #26599 * stream: * implement Readable.from async iterator utility (Guy Bedford) #27660 * make Symbol.asyncIterator support stable (Matteo Collina) #26989 PR-URL: #29875
BethGriggs force-pushed the v10.17.0-proposal branch from 0dc0160 to 5dae3ef Compare BridgeAR approved these changes Oct 22, 2019
BethGriggs added a commit that referenced this pull request Oct 22, 2019
Notable changes: * crypto: * add support for chacha20-poly1305 for AEAD (chux0519) #24081 * increase maxmem range from 32 to 53 bits (Tobias Nießen) #28799 * deps: * update npm to 6.11.3 (claudiahdz) #29430 * upgrade openssl sources to 1.1.1d (Sam Roberts) #29921 * dns: * remove dns.promises experimental warning (cjihrig) #26592 * fs: * remove experimental warning for fs.promises (Anna Henningsen) #26581 * http: * makes response.writeHead return the response (Mark S. Everitt) #25974 * http2: * makes response.writeHead return the response (Mark S. Everitt) #25974 * n-api: * make func argument of napi\_create\_threadsafe\_function optional (legendecas) #27791 * mark version 5 N-APIs as stable (Gabriel Schulhof) #29401 * implement date object (Jarrod Connolly) #25917 * process: * add --unhandled-rejections flag (Ruben Bridgewater) #26599 * stream: * implement Readable.from async iterator utility (Guy Bedford) #27660 * make Symbol.asyncIterator support stable (Matteo Collina) #26989 PR-URL: #29875
BethGriggs added a commit to BethGriggs/nodejs.org that referenced this pull request Oct 22, 2019
BethGriggs added a commit to nodejs/nodejs.org that referenced this pull request Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
2019-10-22, Version 10.17.0 'Dubnium' (LTS), @BethGriggs
Notable changes
Commits
f1a5a36961] - build: update Windows icon to Feb 2016 rebrand (Mike MacCana) #285244f0f12c3d6] - crypto: fix rsa key gen with non-default exponent (Sam Roberts) #270927735824d2c] - (SEMVER-MINOR) crypto: increase maxmem range from 32 to 53 bits (Tobias Nießen) #28799333963ef73] - deps: dlloads node static linked executable (Luca Lindhorst) #280457202792ad3] - deps: update archs files for OpenSSL-1.1.1d (Sam Roberts) #299219c393f1d02] - deps: upgrade openssl sources to 1.1.1d (Sam Roberts) #299217f48519413] - deps: do not link against librt (Sam Roberts) #29729fcc22d31a0] - (SEMVER-MINOR) dns: make dns.promises enumerable (cjihrig) #26592fa27aac5fb] - (SEMVER-MINOR) dns: remove dns.promises experimental warning (cjihrig) #2659290fb146933] - (SEMVER-MINOR) doc: move dns.promises to stable status (cjihrig) #2659265e68d1f4f] - doc: add documentation for stream readableFlowing (Chetan Karande) #29506c285e694e2] - doc: fix the links tls default version sections (Chetan Karande) #28827cef5010135] - doc: describe tls.DEFAULT_MIN_VERSION/_MAX_VERSION (Chetan Karande) #2882715c2eb0e58] - doc: update N-API version matrix (Gabriel Schulhof) #29461a3eda2896d] - doc: fixup changelog for v10.16.3 (Andrew Hughes) #2915956a834a53f] - doc,test: clarify that Http2Stream is destroyed after data is read (Alba Mendez) #2789185ce8ef19a] - (SEMVER-MINOR) fs: remove experimental warning for fs.promises (Anna Henningsen) #26581ccf2823f83] - (SEMVER-MINOR) http: makes response.writeHead return the response (Mark S. Everitt) #2597466387cd45e] - http2: send out pending data earlier (Anna Henningsen) #29398925849650b] - (SEMVER-MINOR) http2: makes response.writeHead return the response (Mark S. Everitt) #2597469b0212df3] - http2: do not start reading after write if new write is on wire (Anna Henningsen) #2939936a0e9a063] - http2: do not crash on stream listener removal w/ destroyed session (Anna Henningsen) #29459c74c6a5ccf] - n-api: mark version 5 N-APIs as stable (Gabriel Schulhof) #29401f8622762e3] - (SEMVER-MINOR) n-api: make func argument of napi_create_threadsafe_function optional (legendecas) #277914f41e4f471] - (SEMVER-MINOR) n-api: implement date object (Jarrod Connolly) #2591769bf5b7944] - net: treat ENOTCONN at shutdown as success (Anna Henningsen) #29912d6c998a478] - process: use public readableFlowing property (Chetan Karande) #29502b43d7e8f42] - (SEMVER-MINOR) process: add --unhandled-rejections flag (Ruben Bridgewater) #2659979f3844fb0] - (SEMVER-MINOR) readline: make Symbol.asyncIterator support stable (Matteo Collina) #2698918b140ae75] - src: use maybe version v8::Function::Call (Ouyang Yadong) #238261bb5102999] - src: use more explicit return type in Sign::SignFinal() (Anna Henningsen) #23779859d47593e] - src: reduce platform worker barrier lifetime (Ali Ijaz Sheikh) #2341900831f0293] - (SEMVER-MINOR) stream: make Symbol.asyncIterator support stable (Matteo Collina) #26989ddb5152e9b] - (SEMVER-MINOR) stream: implement Readable.from async iterator utility (Guy Bedford) #2766013d8549abd] - test: well-defined DH groups now verify clean (Sam Roberts) #29550f78ecc3f93] - test: fix race in test-http2-origin (Alba Mendez) #289032afbb3efab] - test,win: cleanup exec-timeout processes (João Reis) #28723fe58bca878] - tls: group chunks into TLS segments (Alba Mendez) #278612eae030a4b] - (SEMVER-MINOR) worker: add missing return value in case of fatal exceptions (Ruben Bridgewater) #29036e8c90bf4d1] - zlib: do not coalesce multiple.flush()calls (Anna Henningsen) #28520