doc: fix tls version values #29839
Closed
doc: fix tls version values #29839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc 
Trott approved these changes Oct 4, 2019
Member
| Could you also fix up the similar values in |
Collaborator
| CI: https://ci.nodejs.org/job/node-test-pull-request/25839/ (I kicked off CLI because I'm curious if the main branch is currently flapping for some builds; seems like I'd bumped in to a blip). |
cjihrig approved these changes Oct 4, 2019
arzzen approved these changes Oct 4, 2019
codebytere approved these changes Oct 4, 2019
devnexen approved these changes Oct 4, 2019
lpinca approved these changes Oct 4, 2019
trivikr approved these changes Oct 4, 2019
richardlau approved these changes Oct 5, 2019
danbev added the author ready 
tniessen added a commit that referenced this pull request Oct 10, 2019
PR-URL: #29839 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Member Author
| Landed in 36e83ef, thanks for reviewing! |
targos pushed a commit that referenced this pull request Oct 14, 2019
PR-URL: #29839 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
tniessen removed the author ready 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Some of these values are formatted as strings, fix the formatting of the newer values.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes