util: hide toStringTags if already included in the constructor

[BridgeAR]

This makes sure that Symbol.toStringTag entries won't be taken
into account when inspecting objects with util.inspect() in case
the tag is already included in the found constructor name.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[nodejs-github-bot]

Sadly, an error occurred when I tried to trigger a build. :(
CI: https://ci.nodejs.org/job/node-test-pull-request/23866/

[Trott]

CI: https://ci.nodejs.org/job/node-test-pull-request/23866/

[TimothyGu]

I’m not convinced this is a good idea. This would elide the toStringTag even for completely irrelevant class names where toStringTag would be helpful, like Maple [Map].

[BridgeAR]

@TimothyGu that is a very valid point. I could verify that a following letter is a capital letter.

[TimothyGu]

@BridgeAR

that is a very valid point. I could verify that a following letter is a capital letter.

I don't think that's good either. What if the following code point is a number? an underscore? Chinese character? Coptic numeral?

In my view, doing anything other than the current one makes the function even more opinionated than it is, and also brings tremendous complexity to a function already touching on the boundaries of what we stand for as a "small core."

[BridgeAR]

I don't have a strong opinion on this, it was just a thought to reduce duplication.
Thanks for the feedback.