module: remove usage of require('util') #26805
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Use `require('internal/util/debuglog').debuglog` instead of `require('util').debuglog` in `lib/internal/modules/esm/module_map.js`. Refs: nodejs#26546 
BridgeAR approved these changes Mar 22, 2019
Member
BridgeAR added the author ready 
jasnell approved these changes Mar 22, 2019
Member
ZYSzys approved these changes Mar 24, 2019
Member
| Landed in 25b78c0 🎉 |
ZYSzys pushed a commit that referenced this pull request Mar 24, 2019
Use `require('internal/util/debuglog').debuglog` instead of `require('util').debuglog` in `lib/internal/modules/esm/module_map.js`. Refs: #26546 PR-URL: #26805 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
Use `require('internal/util/debuglog').debuglog` instead of `require('util').debuglog` in `lib/internal/modules/esm/module_map.js`. Refs: nodejs#26546 PR-URL: nodejs#26805 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> targos pushed a commit that referenced this pull request Mar 27, 2019
Use `require('internal/util/debuglog').debuglog` instead of `require('util').debuglog` in `lib/internal/modules/esm/module_map.js`. Refs: #26546 PR-URL: #26805 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com> 
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Use
require('internal/util/debuglog').debugloginstead ofrequire('util').debugloginlib/internal/modules/esm/module_map.js.Refs: #26546
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes