Skip to content

lib: reduce usage of require('util') #26784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

lib: reduce usage of require('util') #26784

wants to merge 1 commit into from

Conversation

@toshi1127
Copy link
Contributor

@toshi1127 toshi1127 commented Mar 19, 2019

Remove the usage of public require('util')
Replace require('util').debuglog with require('internal/util/debuglog').debuglog
Replace require('util').format with require('internal/util/inspect').format, as described in issue:
#26546

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows [commit guidelines]
@nodejs-github-bot nodejs-github-bot added dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Mar 19, 2019
@toshi1127 toshi1127 mentioned this pull request Mar 20, 2019
Closed
@BridgeAR
Copy link
Member

BridgeAR commented Mar 22, 2019

CI https://ci.nodejs.org/job/node-test-pull-request/21772/
@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 22, 2019
@joyeecheung joyeecheung mentioned this pull request Mar 22, 2019
Closed
@BridgeAR
Copy link
Member

BridgeAR commented Mar 22, 2019

Resumed CI https://ci.nodejs.org/job/node-test-pull-request/21791/
@ZYSzys
Copy link
Member

ZYSzys commented Mar 24, 2019

Landed in b8d4baf 🎉
@ZYSzys ZYSzys closed this Mar 24, 2019
ZYSzys pushed a commit that referenced this pull request Mar 24, 2019
@toshi1127 @ZYSzys
http2: reduce usage of require('util')
b8d4baf 
PR-URL: #26784 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@ZYSzys ZYSzys mentioned this pull request Mar 25, 2019
Closed
2 tasks
targos pushed a commit to targos/node that referenced this pull request Mar 27, 2019
@toshi1127 @targos
http2: reduce usage of require('util')
d631197 
PR-URL: nodejs#26784 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
targos pushed a commit that referenced this pull request Mar 27, 2019
@toshi1127 @targos
http2: reduce usage of require('util')
15af519 
PR-URL: #26784 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
@targos targos mentioned this pull request Mar 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http2 Issues or PRs related to the http2 subsystem.

5 participants

@toshi1127 @BridgeAR @ZYSzys @jasnell @nodejs-github-bot