repl: add autocomplete for filesystem modules #26648

antsmartian · 2019-03-14T01:50:58Z

This is a implementation of: #17764

~~There are other few things to be done like handling autocompletion for filenames etc.~~
~~Marking it as WIP. But would love to get feedback from @nodejs/repl~~

nodejs-github-bot · 2019-03-14T01:51:00Z

@antsmartian build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/2899/pipeline

lib/repl.js

antsmartian · 2019-03-20T00:52:31Z

@devsnek @richardlau @nodejs/repl PTAL..

antsmartian · 2019-03-20T02:06:56Z

CI: https://ci.nodejs.org/job/node-test-pull-request/21680/

lib/repl.js

test/parallel/test-repl-tab-complete.js

BridgeAR

This is overall looking very promising. I believe this should be good to go after addressing my comments.

lib/repl.js

test/parallel/test-repl-tab-complete.js

antsmartian · 2019-04-20T14:25:49Z

@BridgeAR Thanks much for the follow up and I'm sorry for being late here. I have fixed up the comments, could you please have a look at them?

BridgeAR

LGTM with my comment addressed.

lib/repl.js

antsmartian · 2019-04-21T12:37:49Z

@BridgeAR Have fixed your comments, PTAL.

BridgeAR

LGTM. I found one more small thing that won't change the behavior but filter should always be a string or undefined. Using false adds another map (internal V8 type, also called hidden class) to it.

Thanks for following up on the comments!

BridgeAR · 2019-04-21T22:05:39Z

lib/repl.js

Suggested change

filter = false;

filter = '';

nodejs-github-bot · 2019-04-21T22:10:51Z

CI: https://ci.nodejs.org/job/node-test-pull-request/22608/

antsmartian · 2019-04-25T14:46:09Z

@BridgeAR @nodejs/repl PTAL.. Thanks!

nodejs-github-bot · 2019-04-27T04:03:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/22744/

antsmartian · 2019-04-27T04:04:17Z

@nodejs/repl Can I get one more review, please. Planning to land by April 29th if there are no objections.

nodejs-github-bot · 2019-04-27T05:25:05Z

CI: https://ci.nodejs.org/job/node-test-pull-request/22745/

antsmartian · 2019-04-27T07:10:39Z

@BridgeAR I have addressed your comments regarding filter, PTAL and see if its looks good.. Thanks!

BridgeAR · 2019-04-27T09:12:42Z

Still LGTM

antsmartian · 2019-04-29T01:59:43Z

Landed in d69f004 🎉

PR-URL: #26648 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Notable changes: * deps: * Updated llhttp to 1.1.3. This fixes a bug that made Node.js' HTTP parser refuse any request URL that contained the "|" (vertical bar) character. #27595 * tls: * Added an `enableTrace()` method to `TLSSocket` and an `enableTrace` option to `tls.createServer()`. When enabled, TSL packet trace information is written to `stderr`. This can be used to debug TLS connection problems. #27497 #27376 * cli: * Added a `--trace-tls` command-line flag that enables tracing of TLS connections without the need to modify existing application code. #27497 * Added a `--cpu-prof-interval` command-line flag. It can be used to specify the sampling interval for the CPU profiles generated by `--cpu-prof`. #27535 * module: * Added the `createRequire()` method. It allows to create a require function from a file URL object, a file URL string or an absolute path string. The existing `createRequireFromPath()` method is now deprecated #27405. * Throw on `require('./path.mjs')`. This is technically a breaking change that should have landed with Node.js 12.0.0. It is necessary to have this to keep the possibility for a future minor version to load ES Modules with the require function. #27417 * repl: * The REPL now supports multi-line statements using `BigInt` literals as well as public and private class fields and methods. #27400 * The REPL now supports tab autocompletion of file paths with `fs` methods. #26648 * meta: * Added Christian Clauss (https://github.com/cclauss) to collaborators. #27554 PR-URL: #27578

rauschma · 2019-05-18T01:42:07Z

Small bug on macOS (when, e.g., in /Users/rauschma):

fs.readFileSync('Pub<tab> EXPECTED: fs.readFileSync('Public ACTUAL: fs.readFileSync('Pubublic

jabr · 2019-07-19T18:06:37Z

Not sure if it counts as a bug, but it doesn't work with fs.promises. functions.

nodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label Mar 14, 2019

devsnek reviewed Mar 14, 2019

View reviewed changes

lib/repl.js Outdated Show resolved Hide resolved

richardlau reviewed Mar 14, 2019

View reviewed changes

lib/repl.js Outdated Show resolved Hide resolved

antsmartian added the wip Issues and PRs that are still a work in progress. label Mar 14, 2019

antsmartian force-pushed the add_filelist_tab branch from bc9a014 to d4fec28 Compare March 20, 2019 00:50

antsmartian removed the wip Issues and PRs that are still a work in progress. label Mar 20, 2019

antsmartian force-pushed the add_filelist_tab branch from d4fec28 to 20e96d1 Compare March 20, 2019 00:53

antsmartian changed the title ~~(WIP) repl: add autocomplete for filesystem modules~~ repl: add autocomplete for filesystem modules Mar 20, 2019

antsmartian force-pushed the add_filelist_tab branch from 20e96d1 to 76b01ec Compare March 22, 2019 00:36

joyeecheung mentioned this pull request Mar 22, 2019

CI failures: 20190322 nodejs/reliability#21

Closed

BridgeAR reviewed Mar 25, 2019

View reviewed changes

lib/repl.js Outdated Show resolved Hide resolved

test/parallel/test-repl-tab-complete.js Outdated Show resolved Hide resolved

BridgeAR reviewed Apr 16, 2019

View reviewed changes

antsmartian force-pushed the add_filelist_tab branch from 76b01ec to 8b666b2 Compare April 20, 2019 14:23

BridgeAR approved these changes Apr 20, 2019

View reviewed changes

lib/repl.js Outdated Show resolved Hide resolved

antsmartian force-pushed the add_filelist_tab branch from 8b666b2 to b8cebd3 Compare April 21, 2019 05:26

BridgeAR approved these changes Apr 21, 2019

View reviewed changes

lib/repl.js Outdated

Copy link

Member

BridgeAR Apr 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

filter = false;

filter = '';

repl: add autocomplete for filesystem modules

01102c4

antsmartian force-pushed the add_filelist_tab branch from b8cebd3 to 01102c4 Compare April 25, 2019 14:45

antsmartian added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 27, 2019

antsmartian closed this Apr 29, 2019

antsmartian deleted the add_filelist_tab branch April 29, 2019 02:00

antsmartian added a commit that referenced this pull request Apr 29, 2019

repl: add autocomplete for filesystem modules

d69f004

PR-URL: #26648 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

targos pushed a commit that referenced this pull request Apr 29, 2019

repl: add autocomplete for filesystem modules

149412c

PR-URL: #26648 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

targos mentioned this pull request May 6, 2019

v12.2.0 proposal #27578

Merged

antsmartian mentioned this pull request May 6, 2019

Feature request: Autocomplete filenames for fs functions in repl #17764

Closed

addaleax added backport-blocked-v12.x notable-change PRs with changes that should be highlighted in changelogs. and removed backport-blocked-v12.x labels May 6, 2019

antsmartian mentioned this pull request Sep 2, 2019

repl: add autocomplete support for fs.promises #29400

Closed

4 tasks

ZYSzys mentioned this pull request Sep 3, 2019

repl: bug in fs module autocompletion #29424

Closed

ZYSzys mentioned this pull request Sep 14, 2019

repl: fix bug in fs module autocompletion #29555

Closed

3 tasks

MylesBorins added the semver-minor PRs that contain new features and should be released in the next minor version. label Jan 12, 2020

Uh oh!

repl: add autocomplete for filesystem modules #26648

repl: add autocomplete for filesystem modules #26648

Uh oh!

Conversation

antsmartian commented Mar 14, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

nodejs-github-bot commented Mar 14, 2019

Uh oh!

Uh oh!

antsmartian commented Mar 20, 2019

antsmartian commented Mar 20, 2019

Uh oh!

Uh oh!

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

antsmartian commented Apr 20, 2019

BridgeAR left a comment

Choose a reason for hiding this comment

Uh oh!

antsmartian commented Apr 21, 2019

BridgeAR left a comment

Choose a reason for hiding this comment

BridgeAR Apr 21, 2019

Choose a reason for hiding this comment

nodejs-github-bot commented Apr 21, 2019

antsmartian commented Apr 25, 2019

nodejs-github-bot commented Apr 27, 2019

antsmartian commented Apr 27, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

nodejs-github-bot commented Apr 27, 2019

antsmartian commented Apr 27, 2019

BridgeAR commented Apr 27, 2019

antsmartian commented Apr 29, 2019

rauschma commented May 18, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

jabr commented Jul 19, 2019

Labels

9 participants

antsmartian commented Mar 14, 2019 •

edited

Loading

antsmartian commented Apr 27, 2019 •

edited

Loading

rauschma commented May 18, 2019 •

edited

Loading