Skip to content

Conversation

@vsemozhetbyt
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
  • Fix heading levels.
  • Fix section sorting.
  • Add quotes around string values.
  • Remove quotes around property names.
* Fix heading levels. * Fix section sorting. * Add quotes around string values. * Remove quotes around property names.
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Mar 5, 2019
@vsemozhetbyt vsemozhetbyt added process Issues and PRs related to the process subsystem. report Issues and PRs related to process.report. labels Mar 5, 2019
@vsemozhetbyt
Copy link
Contributor Author

Node.js Collaborators, please, add 👍 here if you approve fast-tracking.

Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

console.log(`Report directory is ${process.report.directory}`);
```

### process.report.filename
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sad thing is that I tried to put this in the right place but can't alphabet apparently. Sorry

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've got too much on your plate to be sorry about missing nits))

@vsemozhetbyt vsemozhetbyt added fast-track PRs that do not need to wait for 48 hours to land. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Mar 5, 2019
@vsemozhetbyt
Copy link
Contributor Author

Landed in 60aaf2c
Thank you for the reviews.

vsemozhetbyt added a commit that referenced this pull request Mar 5, 2019
* Fix heading levels. * Fix section sorting. * Add quotes around string values. * Remove quotes around property names. PR-URL: #26461 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@vsemozhetbyt vsemozhetbyt deleted the doc-report-nits branch March 5, 2019 22:52
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
* Fix heading levels. * Fix section sorting. * Add quotes around string values. * Remove quotes around property names. PR-URL: nodejs#26461 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. process Issues and PRs related to the process subsystem. report Issues and PRs related to process.report.

4 participants