src: fix return type in Hash #25936
Closed
src: fix return type in Hash #25936
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the c++ 
addaleax reviewed Feb 5, 2019
gengjiawen force-pushed the fix_type_in_Hash branch 2 times, most recently from 00f859a to f37d729 Compare 
gengjiawen force-pushed the fix_type_in_Hash branch from f37d729 to 42fda05 Compare addaleax approved these changes Feb 5, 2019
bnoordhuis approved these changes Feb 5, 2019
cjihrig approved these changes Feb 5, 2019
jasnell approved these changes Feb 5, 2019
Contributor
Member
| Landed in ea2350b |
addaleax pushed a commit that referenced this pull request Feb 9, 2019
PR-URL: #25936 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Feb 10, 2019
PR-URL: #25936 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes