doc: improve doc on unintended breaking changes #25887
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Improve the material in the Collaborator Guide on unintended breaking changes.
vsemozhetbyt approved these changes Feb 2, 2019
vsemozhetbyt added the meta 
lpinca approved these changes Feb 2, 2019
Trott added the author ready 
antsmartian approved these changes Feb 3, 2019
| Landed in 3fe9267 |
Trott added a commit to Trott/io.js that referenced this pull request Feb 4, 2019
Improve the material in the Collaborator Guide on unintended breaking changes. PR-URL: nodejs#25887 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
addaleax pushed a commit that referenced this pull request Feb 6, 2019
Improve the material in the Collaborator Guide on unintended breaking changes. PR-URL: #25887 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Merged
This was referenced Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Improve the material in the Collaborator Guide on unintended breaking
changes.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes