report: separate release metadata #25826
Merged
+36 −10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the c++ 
addaleax approved these changes Jan 30, 2019
joyeecheung approved these changes Jan 30, 2019
doc/api/report.md Outdated
There was a problem hiding this comment.
Should we document other fields for a normal release build?
There was a problem hiding this comment.
Possibly, but a normal release build wouldn't be: "nodejsVersion": "v12.0.0-pre",.
cjihrig approved these changes Jan 30, 2019
richardlau force-pushed the reportrelease branch from f6ad48a to ede0655 Compare 
Report release metadata separately from `componentVersions`. Test `componentVersions` and `release` values in the report. PR-URL: nodejs#25826 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
richardlau force-pushed the reportrelease branch from ede0655 to d0d84b0 Compare | Landed in d0d84b0. |
addaleax pushed a commit that referenced this pull request Feb 1, 2019
Report release metadata separately from `componentVersions`. Test `componentVersions` and `release` values in the report. PR-URL: #25826 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This was referenced Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Report release metadata separately from
componentVersions.Test
componentVersionsandreleasevalues in the report.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes