process: move deprecation warning initialization into pre_execution.js #25825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the lib / src 
addaleax approved these changes Jan 30, 2019
lib/internal/main/worker_thread.js Outdated
There was a problem hiding this comment.
Is there any point in trying to group these 4 or 5 calls into a single one, possibly with an options object that indicates which parts of the setup to run?
There was a problem hiding this comment.
I've tried that before but a single call seems to hide too much details - I think it should be fine to directly drop some of the calls, for example, initializeClusterIPC in repl.js. Also the order in which these executes matters to some extent and an option object would blur that.
Maybe we could group them by different modes, but I cannot think of good names for those modes off the top of my head.
danbev approved these changes Feb 6, 2019
jasnell approved these changes Feb 6, 2019
Since this is only necessary when user code execution is expected.
joyeecheung force-pushed the deprecation-move branch from e137006 to 3f61246 Compare 
joyeecheung added the author ready | Landed in 09a5f02 |
joyeecheung added a commit that referenced this pull request Feb 8, 2019
Since this is only necessary when user code execution is expected. PR-URL: #25825 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Feb 10, 2019
Since this is only necessary when user code execution is expected. PR-URL: #25825 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This was referenced Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Since this is only necessary when user code execution is expected.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes