Skip to content

[v11.x] deps: cherry-pick d9fbfeb from upstream V8 #25331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[v11.x] deps: cherry-pick d9fbfeb from upstream V8 #25331

wants to merge 1 commit into from

Conversation

@kjin
Copy link
Contributor

@kjin kjin commented Jan 3, 2019

Original commit message:

inspector: return [[StableObjectId]] as internal property This property might be useful for fast '===' check. R=dgozman@chromium.org,yangguo@chromium.org Bug: none Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Iabc3555ce1ec2c14cf0ccd40b7d964ae144e7352 Reviewed-on: https://chromium-review.googlesource.com/1226411 Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Reviewed-by: Yang Guo <yangguo@chromium.org> Reviewed-by: Jakob Gruber <jgruber@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#56095}

See: #23886

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
@alexkozy @kjin
deps: cherry-pick d9fbfeb from upstream V8
7c087b1 
Original commit message:	inspector: return [[StableObjectId]] as internal property	This property might be useful for fast '===' check.	R=dgozman@chromium.org,yangguo@chromium.org	Bug: none	Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel	Change-Id: Iabc3555ce1ec2c14cf0ccd40b7d964ae144e7352	Reviewed-on: https://chromium-review.googlesource.com/1226411	Reviewed-by: Dmitry Gozman <dgozman@chromium.org>	Reviewed-by: Yang Guo <yangguo@chromium.org>	Reviewed-by: Jakob Gruber <jgruber@chromium.org>	Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>	Cr-Commit-Position: refs/heads/master@{nodejs#56095}
@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v11.x v8 engine Issues and PRs related to the V8 dependency. labels Jan 3, 2019
bnoordhuis
bnoordhuis approved these changes Jan 6, 2019
View reviewed changes
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

Node.js CI: https://ci.nodejs.org/job/node-test-pull-request/19957/
V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/1986/
@bnoordhuis
Copy link
Member

bnoordhuis commented Jan 7, 2019

The test failure is #24005 and not caused by this PR:

14:08:41 not ok 527 parallel/test-worker-cleanup-handles 14:08:41 --- 14:08:41 duration_ms: 120.106 14:08:41 severity: fail 14:08:41 exitcode: 1 14:08:41 stack: |- 14:08:41 timeout 14:08:41 ...
@BridgeAR
Copy link
Member

BridgeAR commented Jan 9, 2019

Resumed CI https://ci.nodejs.org/job/node-test-pull-request/20035/
V8 CI https://ci.nodejs.org/job/node-test-commit-v8-linux/1995/
BridgeAR pushed a commit that referenced this pull request Jan 9, 2019
@alexkozy @BridgeAR
deps: cherry-pick d9fbfeb from upstream V8
e1d4f43 
Original commit message:	inspector: return [[StableObjectId]] as internal property	This property might be useful for fast '===' check.	R=dgozman@chromium.org,yangguo@chromium.org	Bug: none	Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel	Change-Id: Iabc3555ce1ec2c14cf0ccd40b7d964ae144e7352	Reviewed-on: https://chromium-review.googlesource.com/1226411	Reviewed-by: Dmitry Gozman <dgozman@chromium.org>	Reviewed-by: Yang Guo <yangguo@chromium.org>	Reviewed-by: Jakob Gruber <jgruber@chromium.org>	Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>	Cr-Commit-Position: refs/heads/master@{#56095} PR-URL: #25331 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR
Copy link
Member

BridgeAR commented Jan 9, 2019

Landed in e1d4f43 🎉
@BridgeAR BridgeAR closed this Jan 9, 2019
@BridgeAR BridgeAR mentioned this pull request Jan 16, 2019
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
@alexkozy @BridgeAR
deps: cherry-pick d9fbfeb from upstream V8
f0e876f 
Original commit message:	inspector: return [[StableObjectId]] as internal property	This property might be useful for fast '===' check.	R=dgozman@chromium.org,yangguo@chromium.org	Bug: none	Cq-Include-Trybots: luci.chromium.try:linux_chromium_headless_rel;luci.chromium.try:linux_chromium_rel_ng;master.tryserver.blink:linux_trusty_blink_rel	Change-Id: Iabc3555ce1ec2c14cf0ccd40b7d964ae144e7352	Reviewed-on: https://chromium-review.googlesource.com/1226411	Reviewed-by: Dmitry Gozman <dgozman@chromium.org>	Reviewed-by: Yang Guo <yangguo@chromium.org>	Reviewed-by: Jakob Gruber <jgruber@chromium.org>	Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org>	Cr-Commit-Position: refs/heads/master@{nodejs#56095} PR-URL: nodejs#25331 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@MylesBorins MylesBorins mentioned this pull request Jan 24, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.

5 participants

@kjin @bnoordhuis @BridgeAR @nodejs-github-bot @alexkozy