src: fulfill Maybe contract in InlineDecoder #25140
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Use an empty/nothing `Maybe<>` to indicate a pending exception.
nodejs-github-bot added buffer 
cjihrig approved these changes Dec 19, 2018
joyeecheung approved these changes Dec 19, 2018
codebytere approved these changes Dec 20, 2018
jasnell approved these changes Dec 20, 2018
Member Author
addaleax added the author ready Member Author
| Landed in b4b9e0e |
addaleax added a commit that referenced this pull request Dec 30, 2018
Use an empty/nothing `Maybe<>` to indicate a pending exception. PR-URL: #25140 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jan 1, 2019
Use an empty/nothing `Maybe<>` to indicate a pending exception. PR-URL: #25140 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
Use an empty/nothing `Maybe<>` to indicate a pending exception. PR-URL: nodejs#25140 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Merged
BethGriggs pushed a commit that referenced this pull request Jul 2, 2019
Use an empty/nothing `Maybe<>` to indicate a pending exception. PR-URL: #25140 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs pushed a commit that referenced this pull request Jul 17, 2019
Use an empty/nothing `Maybe<>` to indicate a pending exception. PR-URL: #25140 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Use an empty/nothing
Maybe<>to indicate a pending exception.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes