Update docs for http request set timeout #25121
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the child_process 2 tasks
Contributor
| I'm confused. This PR currently contains more than a documentation change. |
jbunton-atlassian force-pushed the update_docs_for_http_request_setTimeout branch from ed4ac0d to 84cd47b Compare Contributor Author
| @mscdex, sorry again! I created these doc commits from a branch where I'm trying to track down another problem. I've rebased to exclude the non-doc change. |
2 tasks
lpinca reviewed Dec 19, 2018
lpinca added http jbunton-atlassian force-pushed the update_docs_for_http_request_setTimeout branch from 84cd47b to 2b4d26a Compare lpinca approved these changes Dec 19, 2018
Contributor Author
| Thanks @lpinca :) |
jbunton-atlassian force-pushed the update_docs_for_http_request_setTimeout branch 2 times, most recently from 84cd47b to 2b4d26a Compare 
jbunton-atlassian force-pushed the update_docs_for_http_request_setTimeout branch from 2b4d26a to 5708c6a Compare 
Contributor
addaleax approved these changes Dec 21, 2018
jasnell approved these changes Dec 27, 2018
Contributor Author
| Hi there, could somebody please merge this for me? Thanks! |
vsemozhetbyt added the author ready Contributor
| Landed in b83088b |
Merged
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Jan 16, 2019
PR-URL: nodejs#25121 Refs: nodejs#8895 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Merged
This was referenced May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
When upgrading from Node.js 8 to 10 I hit the behaviour change in #8895. This documentation update would have helped me find the problem faster :)
Also see #25123 for an update to the v8.x docs.
Thanks :)
Checklist