test: do not lint macros files (again) #24886
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added lib / src 
Trott approved these changes Dec 7, 2018
Member
Member
| Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19371/ |
Contributor Author
| ;-) These are COMMENTS in the code. |
targos approved these changes Dec 11, 2018
Member
| As this change only affects comments, lite CI is enough: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/1893/ ✔️ |
Contributor
| Landed in 50cf6e7. |
BethGriggs pushed a commit that referenced this pull request Dec 17, 2018
PR-URL: #24886 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
PR-URL: nodejs#24886 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
PR-URL: #24886 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
PR-URL: #24886 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
PR-URL: #24886 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR is #24885 but without the modifications to deps/v8/src/js/macros.py
These three .py files do not contain any Python code. Instead they contain "macros" which are processed by js2c.py. Our Python linter (make lint-py) will properly flag these files as containing Python syntax errors. One solution would be to change the filename suffixes (.py -->.js2c) or we could add a linter directive (# noqa) to the comments of each file to tell our linter to ignore those files. This PR implements the latter.
@targos Your review please.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes