test: improve test-net-socket-timeout #24859
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
* Check for custom Node.js code rather than constructor in assert.throws(). * Use arrow functions consistently.
Member Author
cjihrig approved these changes Dec 5, 2018
Member Author
| Resume Build CI: https://ci.nodejs.org/job/node-test-pull-request/19251/ ✔️ |
richardlau approved these changes Dec 6, 2018
Trott added the author ready 
trivikr approved these changes Dec 8, 2018
Trott added a commit to Trott/io.js that referenced this pull request Dec 8, 2018
* Check for custom Node.js code rather than constructor in assert.throws(). * Use arrow functions consistently. PR-URL: nodejs#24859 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Member Author
| Landed in 6780683 |
targos pushed a commit that referenced this pull request Dec 8, 2018
* Check for custom Node.js code rather than constructor in assert.throws(). * Use arrow functions consistently. PR-URL: #24859 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
* Check for custom Node.js code rather than constructor in assert.throws(). * Use arrow functions consistently. PR-URL: nodejs#24859 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
* Check for custom Node.js code rather than constructor in assert.throws(). * Use arrow functions consistently. PR-URL: #24859 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
* Check for custom Node.js code rather than constructor in assert.throws(). * Use arrow functions consistently. PR-URL: #24859 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
* Check for custom Node.js code rather than constructor in assert.throws(). * Use arrow functions consistently. PR-URL: #24859 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
assert.throws().
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes