doc: add class worker documentation #24849
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add documentation about Worker class inherits from EventEmitter.
lpinca reviewed Dec 5, 2018
I corrected the parts you pointed out.
lpinca approved these changes Dec 11, 2018
vsemozhetbyt approved these changes Dec 11, 2018
vsemozhetbyt added the author ready 
Contributor
Contributor
| Landed in 9fc0b7b |
vsemozhetbyt pushed a commit that referenced this pull request Dec 11, 2018
Add documentation about Worker class inherits from EventEmitter. PR-URL: #24849 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
3 tasks
BethGriggs pushed a commit that referenced this pull request Dec 17, 2018
Add documentation about Worker class inherits from EventEmitter. PR-URL: #24849 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Merged
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
Add documentation about Worker class inherits from EventEmitter. PR-URL: nodejs#24849 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
Add documentation about Worker class inherits from EventEmitter. PR-URL: #24849 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Merged
BethGriggs pushed a commit that referenced this pull request Feb 20, 2019
Add documentation about Worker class inherits from EventEmitter. PR-URL: #24849 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
rvagg pushed a commit that referenced this pull request Feb 28, 2019
Add documentation about Worker class inherits from EventEmitter. PR-URL: #24849 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR is repullrequest(#24809) because I did not read the document carefully and conflict occurred trying to fix. sorry, I am not used to git.
Add documentation about Worker class inherits from EventEmitter.
related #24732
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes