Skip to content

http2: make compat writeHead not crash if the stream is destroyed #24723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

http2: make compat writeHead not crash if the stream is destroyed #24723

wants to merge 2 commits into from

Conversation

@mcollina
Copy link
Member

@mcollina mcollina commented Nov 29, 2018

Fixes: #24470

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Nov 29, 2018

@mcollina build started: https://ci.nodejs.org/blue/organizations/jenkins/node-test-pull-request-lite-pipeline/detail/node-test-pull-request-lite-pipeline/1724/pipeline
@nodejs-github-bot nodejs-github-bot added dont-land-on-v6.x http2 Issues or PRs related to the http2 subsystem. labels Nov 29, 2018
@mcollina
Copy link
Member Author

mcollina commented Nov 29, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19045/
@mcollina
Copy link
Member Author

mcollina commented Nov 29, 2018

cc @StephenLynx
richardlau
richardlau approved these changes Nov 29, 2018
View reviewed changes
@richardlau @mcollina
Update test/parallel/test-http2-compat-write-head-destroyed.js
c54500b 
Co-Authored-By: mcollina <matteo.collina@gmail.com>
@mcollina mcollina mentioned this pull request Nov 29, 2018
Closed
@Trott
Copy link
Member

Trott commented Dec 2, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/19130/
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 2, 2018
@Trott
Copy link
Member

Trott commented Dec 3, 2018

Landed in 32fed93
@Trott Trott closed this Dec 3, 2018
Trott pushed a commit to Trott/io.js that referenced this pull request Dec 3, 2018
@mcollina @Trott
http2: make compat writeHead not crash if the stream is destroyed
32fed93 
Fixes: nodejs#24470 PR-URL: nodejs#24723 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@mcollina mcollina deleted the http2-write-head-do-not-crash branch December 3, 2018 08:54
BridgeAR pushed a commit that referenced this pull request Dec 5, 2018
@mcollina @BridgeAR
http2: make compat writeHead not crash if the stream is destroyed
798504a 
Fixes: #24470 PR-URL: #24723 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
Merged
4 tasks
This was referenced Dec 7, 2018
Closed
Closed
Closed
Closed
Closed
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
@mcollina @refack
http2: make compat writeHead not crash if the stream is destroyed
b287426 
Fixes: nodejs#24470 PR-URL: nodejs#24723 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs pushed a commit that referenced this pull request Feb 12, 2019
@mcollina @BethGriggs
http2: make compat writeHead not crash if the stream is destroyed
f4aed8c 
Fixes: #24470 PR-URL: #24723 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Feb 12, 2019
Merged
rvagg pushed a commit that referenced this pull request Feb 28, 2019
@mcollina @rvagg
http2: make compat writeHead not crash if the stream is destroyed
d56a5e8 
Fixes: #24470 PR-URL: #24723 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@mcollina mcollina mentioned this pull request Apr 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. http2 Issues or PRs related to the http2 subsystem.

7 participants

@mcollina @nodejs-github-bot @Trott @jasnell @lpinca @richardlau @BethGriggs