doc: update fs.open() changes record for optional 'flags' #24240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added doc 
vsemozhetbyt approved these changes Nov 8, 2018
Contributor
| Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
cjihrig approved these changes Nov 8, 2018
Member Author
| hey @vsemozhetbyt & @cjihrig would you mind taking a look at the latest update here? I've given fs.openSync the same treatment and also copied the change doc for the |
vsemozhetbyt approved these changes Nov 9, 2018
Contributor
| @rvagg do the promises versions of these also need to be updated? |
jasnell approved these changes Nov 10, 2018
Member Author
| yeah, |
Contributor
It seems the doc section for - * `flags` {string|number} See [support of file system `flags`][]. + * `flags` {string|number} See [support of file system `flags`][]. **Default:** `'r'`. |
rvagg force-pushed the rvagg/fs.open_history branch from 711db29 to d8479c0 Compare rvagg force-pushed the rvagg/fs.open_history branch from d8479c0 to a39e208 Compare Member Author
| Thanks @vsemozhetbyt, added that change to another fixup commit |
Contributor
vsemozhetbyt added the author ready 
Member
| Landed in 1532232 |
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 12, 2018
Was missed on original PR. Ref: nodejs#23767 PR-URL: nodejs#24240 Refs: nodejs#23767 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
Was missed on original PR. Ref: nodejs#23767 PR-URL: nodejs#24240 Refs: nodejs#23767 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Nov 15, 2018
This was referenced Nov 15, 2018
Merged
This was referenced Jan 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Was missed on original PR.
Ref: #23767