test: fix test-require-symlink on Windows #23691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor Author
cjihrig approved these changes Oct 16, 2018
refack approved these changes Oct 16, 2018
Contributor
| Shouldn't we validate the arg and throw, or assume |
refack added fs Contributor Author
| @refack the API assumes We could add a test to see if link target is a directory and make it automatically use |
jasnell approved these changes Oct 16, 2018
Contributor
👍 (or throw) |
3 tasks
Contributor Author
| Resumed CI, all green: https://ci.nodejs.org/job/node-test-commit/22568/ |
Contributor
| So we actually don't get coverage for this in CI because of: |
Creating directory symlinks on Windows require 'dir' parameter to be provided. Fixes: nodejs#23596 PR-URL: nodejs#23691 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
refack force-pushed the bartek-fix-test-require-symlink branch from 0cbd76c to d1d5924 Compare 
This was referenced Nov 2, 2018
Closed
bzoz added a commit to JaneaSystems/node that referenced this pull request Nov 29, 2018
On Windows creating a symlink to a directory will not work unless extra 'dir' parameter is passed. This adds a check if link target is a directory, and if so automatically use 'dir' when creating symlink. Ref: nodejs#23691
Merged
Trott pushed a commit to Trott/io.js that referenced this pull request Nov 29, 2018
On Windows creating a symlink to a directory will not work unless extra 'dir' parameter is passed. This adds a check if link target is a directory, and if so automatically use 'dir' when creating symlink. PR-URL: nodejs#23724 Refs: nodejs#23691 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
This was referenced Dec 18, 2018
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
On Windows creating a symlink to a directory will not work unless extra 'dir' parameter is passed. This adds a check if link target is a directory, and if so automatically use 'dir' when creating symlink. PR-URL: nodejs#23724 Refs: nodejs#23691 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Creating directory symlinks on Windows require 'dir' parameter to be provided.
Fixes: #23596
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes