src: add NODE_EXTERN to class definition #22559
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This should be part of public class definitions for Windows embedders who use a DLL interface for accessing Node.
addaleax added windows 
nodejs-github-bot added the c++ 
Member Author
| CI: https://ci.nodejs.org/job/node-test-pull-request/16813/ Feel free to 👍 this comment to approve fast-tracking. |
danbev approved these changes Aug 28, 2018
Member Author
cjihrig approved these changes Aug 28, 2018
BridgeAR added the author ready Member Author
Member Author
| Landed in 04060e3 |
addaleax added a commit that referenced this pull request Sep 2, 2018
This should be part of public class definitions for Windows embedders who use a DLL interface for accessing Node. PR-URL: #22559 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Sep 3, 2018
This should be part of public class definitions for Windows embedders who use a DLL interface for accessing Node. PR-URL: #22559 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Sep 6, 2018
This should be part of public class definitions for Windows embedders who use a DLL interface for accessing Node. PR-URL: #22559 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Sep 6, 2018
Collaborator
Member Author
| @joyeecheung You started the CI run above, but I guess it was meant for a different PR? 😄 |
Member
| Um I probably copy-pasted the wrong number, sorry! |
addaleax added the v8 platform Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This should be part of public class definitions for Windows
embedders who use a DLL interface for accessing Node.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes