n-api: refine napi_get_property_names() doc #20427
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Document that only enumerable, string-keyed properties are returned. Fixes: nodejs/abi-stable-node#307
nodejs-github-bot added doc 
vsemozhetbyt approved these changes Apr 30, 2018
Contributor
| Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
Contributor
vsemozhetbyt added fast-track 
TimothyGu approved these changes Apr 30, 2018
Contributor
| Commit message nit: isn't the subsystem |
Contributor Author
| @AyushG3112 I'll land with doc. |
Contributor Author
| Landed in 20eaee5. |
gabrielschulhof pushed a commit that referenced this pull request Apr 30, 2018
Document that only enumerable, string-keyed properties are returned. Fixes: nodejs/abi-stable-node#307 PR-URL: #20427 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 4, 2018
Document that only enumerable, string-keyed properties are returned. Fixes: nodejs/abi-stable-node#307 PR-URL: #20427 Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Document that only enumerable, string-keyed properties are returned.
Fixes: nodejs/abi-stable-node#307
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes