child_process: fix exec set stdout.setEncoding #18976
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the child_process 
lpinca reviewed Feb 24, 2018
Member
There was a problem hiding this comment.
What do you think about using process.{stdout,stderr}.write()?
Contributor Author
| The |
Contributor Author
| @hstarorg Thanks for the advice, you are right.I have a better solution. |
killagu commented Feb 25, 2018
lib/_stream_readable.js Outdated
Contributor Author
There was a problem hiding this comment.
const readStream = new ReadableStream(); readStream.setEncoding(null); // readStream._readableState.decoder.encoding equals 'utf8' // readStream._readableState.encoding equals null;_readableState.encoding should be same as this._readableState.decoder.encoding
Member
| @nodejs/streams PTAL |
mcollina approved these changes Apr 10, 2018
Member
mcollina left a comment
mcollina left a comment There was a problem hiding this comment.
Can you please add a test for Readable alone?
LGTM with that test included.
Member
| Ping @killagu |
Member
Contributor Author
| @BridgeAR I'm sorry it's taken me so long to get back to you. I'll add the test ASAP. |
cp.exec decide to use `_stdout`(_stdout is string) or `Buffer.concat(_stdout)`(_stdout is buffer array) by options.encoding. but std(out|err) encoding can be changed. If encoding is changed to not null, `_stdout` will become string, and `Buffer.concat(_stdout)` will throw TypeError. This patch will fix it, use options.encoding and `std(out|err)._readableState.encoding`. Fixes: nodejs#18969
fix max-buffer fix _stream_readable.setEncoding
killagu force-pushed the fix-cp-exec-set-encoding branch from daf4cae to 72ebad2 Compare Contributor Author
Member
BridgeAR approved these changes May 15, 2018
BridgeAR added the author ready Member
| @nodejs/child_process PTAL |
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 18, 2018
cp.exec decide to use `_stdout`(_stdout is string) or `Buffer.concat(_stdout)`(_stdout is buffer array) by options.encoding. but std(out|err) encoding can be changed. If encoding is changed to not null, `_stdout` will become string, and `Buffer.concat(_stdout)` will throw TypeError. This patch will fix it, use options.encoding and `std(out|err)._readableState.encoding`. PR-URL: nodejs#18976 Fixes: nodejs#18969 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Member
| Landed in 7d81f5d 🎉 |
MylesBorins pushed a commit that referenced this pull request May 22, 2018
cp.exec decide to use `_stdout`(_stdout is string) or `Buffer.concat(_stdout)`(_stdout is buffer array) by options.encoding. but std(out|err) encoding can be changed. If encoding is changed to not null, `_stdout` will become string, and `Buffer.concat(_stdout)` will throw TypeError. This patch will fix it, use options.encoding and `std(out|err)._readableState.encoding`. PR-URL: #18976 Fixes: #18969 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
cp.exec decide to use
_stdout(_stdout is string) orBuffer.concat(_stdout)(_stdout is buffer array) by options.encoding.but std(out|err) encoding can be changed. If encoding is changed to
not null,
_stdoutwill become string, andBuffer.concat(_stdout)will throw TypeError. This patch will fix it, use
options.encoding and
std(out|err)._readableState.encoding.Fixes: #18969
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
child_process