http: remove duplicate export #17982
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jasnell approved these changes Jan 4, 2018
maclover7 approved these changes Jan 4, 2018
lpinca approved these changes Jan 4, 2018
BridgeAR approved these changes Jan 4, 2018
BridgeAR added the author ready 
Member
hiroppy approved these changes Jan 5, 2018
Contributor Author
| I think this is ok to go ahead and land, so doing so now. Thanks! |
evanlucas force-pushed the duplicateexport branch from 4e44837 to 189d29f Compare Contributor Author
| Landed in 189d29f. Thanks! |
MylesBorins pushed a commit that referenced this pull request Jan 8, 2018
5425e0d switched to using the module.exports pattern vs just exports, but left a duplicate export around for OutgoingMessage. PR-URL: #17982 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
5425e0d switched to using the module.exports pattern vs just exports, but left a duplicate export around for OutgoingMessage. PR-URL: #17982 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
MylesBorins pushed a commit that referenced this pull request Jan 9, 2018
5425e0d switched to using the module.exports pattern vs just exports, but left a duplicate export around for OutgoingMessage. PR-URL: #17982 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Merged
TimothyGu removed the author ready MylesBorins pushed a commit that referenced this pull request Jan 24, 2018
5425e0d switched to using the module.exports pattern vs just exports, but left a duplicate export around for OutgoingMessage. PR-URL: #17982 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
5425e0d switched to using
the module.exports pattern vs just exports, but left
a duplicate export around for OutgoingMessage.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
http