test: simplify common.expectsError #17616
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The mustCall is actually only necessary in case it is used as callback. Otherwise it works as a must call on its own.
apapirovski approved these changes Dec 11, 2017
cjihrig approved these changes Dec 11, 2017
Member
addaleax added the author ready 
maclover7 approved these changes Dec 11, 2017
BridgeAR added a commit to BridgeAR/node that referenced this pull request Dec 12, 2017
The mustCall is actually only necessary in case it is used as callback. Otherwise it works as a must call on its own. PR-URL: nodejs#17616 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
Member Author
| Landed in 8d5b3de |
addaleax removed the author ready MylesBorins pushed a commit that referenced this pull request Dec 20, 2017
The mustCall is actually only necessary in case it is used as callback. Otherwise it works as a must call on its own. PR-URL: #17616 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2017
The mustCall is actually only necessary in case it is used as callback. Otherwise it works as a must call on its own. PR-URL: #17616 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
Merged
MylesBorins pushed a commit that referenced this pull request Jan 22, 2018
The mustCall is actually only necessary in case it is used as callback. Otherwise it works as a must call on its own. PR-URL: #17616 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The mustCall is actually only necessary in case it is used as
callback. Otherwise it works as a must call on its own.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test