test: fix flaky test-benchmark-es #17516
Closed
+2 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Allow zero iterations for short benchmark in test.
Trott added benchmark 
Member Author
| Sample failure in CI: https://ci.nodejs.org/job/node-test-commit-linux/14741/nodes=alpine35-container-x64/consoleFull not ok 148 parallel/test-benchmark-es --- duration_ms: 3.27 severity: fail stack: |- es/defaultparams-bench.js es/defaultparams-bench.js millions=0.000001 method="": 0.00597760788087823 es/destructuring-bench.js es/destructuring-bench.js millions=0.000001 method="": 0.007550075878262576 es/destructuring-object-bench.js /home/iojs/build/workspace/node-test-commit-linux/nodes/alpine35-container-x64/benchmark/common.js:202 throw new Error('insufficient clock precision for short benchmark'); ^ Error: insufficient clock precision for short benchmark at Benchmark.end (/home/iojs/build/workspace/node-test-commit-linux/nodes/alpine35-container-x64/benchmark/common.js:202:13) at runNormal (/home/iojs/build/workspace/node-test-commit-linux/nodes/alpine35-container-x64/benchmark/es/destructuring-object-bench.js:21:9) at main (/home/iojs/build/workspace/node-test-commit-linux/nodes/alpine35-container-x64/benchmark/es/destructuring-object-bench.js:43:7) at Benchmark.process.nextTick (/home/iojs/build/workspace/node-test-commit-linux/nodes/alpine35-container-x64/benchmark/common.js:34:28) at process._tickCallback (internal/process/next_tick.js:150:11) at Function.Module.runMain (module.js:703:11) at startup (bootstrap_node.js:195:16) at bootstrap_node.js:646:3 assert.js:42 throw new errors.AssertionError({ ^ AssertionError [ERR_ASSERTION]: 1 strictEqual 0 at ChildProcess.child.on (/home/iojs/build/workspace/node-test-commit-linux/nodes/alpine35-container-x64/test/common/benchmark.js:25:12) at ChildProcess.emit (events.js:126:13) at Process.ChildProcess._handle.onexit (internal/child_process.js:209:12) ... |
Member Author
| CI: https://ci.nodejs.org/job/node-test-pull-request/11934/ [UPDATE: It's green.] |
apapirovski approved these changes Dec 7, 2017
cjihrig approved these changes Dec 7, 2017
Trott added a commit to Trott/io.js that referenced this pull request Dec 9, 2017
Allow zero iterations for short benchmark in test. PR-URL: nodejs#17516 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member Author
| Landed in f01e9e7 |
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
Allow zero iterations for short benchmark in test. PR-URL: #17516 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
Allow zero iterations for short benchmark in test. PR-URL: #17516 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
Allow zero iterations for short benchmark in test. PR-URL: #17516 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
Allow zero iterations for short benchmark in test. PR-URL: #17516 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Allow zero iterations for short benchmark in test.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test benchmark