test: refactor exitedAfterDisconnect test #16729
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Trott added cluster 
cjihrig reviewed Nov 3, 2017
Contributor
There was a problem hiding this comment.
Isn't this changing the check from eventFired === false to, basically, !!eventFired?
Member Author
There was a problem hiding this comment.
Whoops, didn't commit all my changes...let's try again...
* minor refactoring to conform with test-writing layout guidelines * rename test to use current terminology rather than deprecated terminology * assert.strictEqual() -> assert.ok()
Trott force-pushed the refactor-cluster-test branch from fcc9790 to dc4980b Compare 
Member Author
cjihrig approved these changes Nov 3, 2017
eugeneo approved these changes Nov 3, 2017
gireeshpunathil approved these changes Nov 4, 2017
lpinca approved these changes Nov 5, 2017
targos approved these changes Nov 5, 2017
Trott added a commit to Trott/io.js that referenced this pull request Nov 5, 2017
* minor refactoring to conform with test-writing layout guidelines * rename test to use current terminology rather than deprecated terminology * assert.strictEqual() -> assert.ok() PR-URL: nodejs#16729 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Member Author
| Landed in 3a4f0e9 |
cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 6, 2017
* minor refactoring to conform with test-writing layout guidelines * rename test to use current terminology rather than deprecated terminology * assert.strictEqual() -> assert.ok() PR-URL: nodejs#16729 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
MylesBorins pushed a commit that referenced this pull request Nov 14, 2017
* minor refactoring to conform with test-writing layout guidelines * rename test to use current terminology rather than deprecated terminology * assert.strictEqual() -> assert.ok() PR-URL: #16729 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
MylesBorins pushed a commit that referenced this pull request Dec 19, 2017
* minor refactoring to conform with test-writing layout guidelines * rename test to use current terminology rather than deprecated terminology * assert.strictEqual() -> assert.ok() PR-URL: #16729 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
* minor refactoring to conform with test-writing layout guidelines * rename test to use current terminology rather than deprecated terminology * assert.strictEqual() -> assert.ok() PR-URL: #16729 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
terminology
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test cluster