test: remove disabled tls_server.js #12275
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Remove tls_server.js that has been disabled for about 6 years. It appears to have worked in concert with some other file which has since been removed. It seems to create a server and set up a bunch of listeners, but it does not appear to have code that connects to the server and triggers any of those listeners.
richardlau approved these changes Apr 7, 2017
Member
|
Edit: nvm I see the test was removed but not this file. |
hiroppy approved these changes Apr 7, 2017
refack approved these changes Apr 8, 2017
aqrln approved these changes Apr 8, 2017
cjihrig approved these changes Apr 8, 2017
gibfahn approved these changes Apr 9, 2017
Member Author
| CI failures are unrelated / known issues from earlier. But since I like my CI runs green: https://ci.nodejs.org/job/node-test-pull-request/7291/ |
Member Author
Trott added a commit to Trott/io.js that referenced this pull request Apr 11, 2017
Remove tls_server.js that has been disabled for about 6 years. It appears to have worked in concert with some other file which has since been removed. It seems to create a server and set up a bunch of listeners, but it does not appear to have code that connects to the server and triggers any of those listeners. PR-URL: nodejs#12275 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Member Author
| Landed in 569f988 |
3 tasks
gibfahn pushed a commit that referenced this pull request Jun 18, 2017
Remove tls_server.js that has been disabled for about 6 years. It appears to have worked in concert with some other file which has since been removed. It seems to create a server and set up a bunch of listeners, but it does not appear to have code that connects to the server and triggers any of those listeners. PR-URL: #12275 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
gibfahn pushed a commit that referenced this pull request Jun 20, 2017
Remove tls_server.js that has been disabled for about 6 years. It appears to have worked in concert with some other file which has since been removed. It seems to create a server and set up a bunch of listeners, but it does not appear to have code that connects to the server and triggers any of those listeners. PR-URL: #12275 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 11, 2017
Remove tls_server.js that has been disabled for about 6 years. It appears to have worked in concert with some other file which has since been removed. It seems to create a server and set up a bunch of listeners, but it does not appear to have code that connects to the server and triggers any of those listeners. PR-URL: #12275 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Remove tls_server.js that has been disabled for about 6 years. It
appears to have worked in concert with some other file which has since
been removed. It seems to create a server and set up a bunch of
listeners, but it does not appear to have code that connects to the
server and triggers any of those listeners.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test