test: add hasCrypto check to tls-legacy-deprecated #11747
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Currently test-tls-legacy-deprecated will fail if node was built using --without-ssl. This commit adds a check to verify is crypto support exists and if not skip this test.
Contributor Author
cjihrig approved these changes Mar 9, 2017
danbev added a commit to danbev/node that referenced this pull request Mar 10, 2017
Currently test-tls-legacy-deprecated will fail if node was built using --without-ssl. This commit adds a check to verify is crypto support exists and if not skip this test. PR-URL: nodejs#11747 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Contributor Author
| Landed in b98004b |
jungx098 pushed a commit to jungx098/node that referenced this pull request Mar 21, 2017
Currently test-tls-legacy-deprecated will fail if node was built using --without-ssl. This commit adds a check to verify is crypto support exists and if not skip this test. PR-URL: nodejs#11747 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
| This PR need backport to v7 |
Contributor Author
| @italoacasas Sorry again (I've had an issue with my email filter which has cause me to miss some messages, not intentional). Should I still backport this issue? |
Member
No need (although I assume you already know that!) There won't be another 7.x release, and this is in Node 8.x. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently test-tls-legacy-deprecated will fail if node
was built using --without-ssl. This commit adds a check to
verify that crypto support exists and if not skip this test.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test