benchmark: fix punycode and get-ciphers benchmark #11720
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add missing 'i=0' from for-loops from punycode and get-ciphers benchmarks.
nodejs-github-bot added the benchmark 
mscdex added crypto 
cjihrig approved these changes Mar 6, 2017
TimothyGu approved these changes Mar 6, 2017
jasnell approved these changes Mar 6, 2017
lpinca approved these changes Mar 7, 2017
bzoz added a commit to JaneaSystems/node that referenced this pull request Mar 8, 2017
Removes all instances of %OptimizeFunctionOnNextCall from benchmarks Refs: nodejs#9615 Refs: nodejs#11720
3 tasks
Contributor Author
| Landed in 6df23fa |
bzoz added a commit that referenced this pull request Mar 9, 2017
Add missing 'i=0' from for-loops from punycode and get-ciphers benchmarks. PR-URL: #11720 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
jungx098 pushed a commit to jungx098/node that referenced this pull request Mar 21, 2017
Add missing 'i=0' from for-loops from punycode and get-ciphers benchmarks. PR-URL: nodejs#11720 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Mar 21, 2017
Removes all instances of %OptimizeFunctionOnNextCall from benchmarks Refs: nodejs#9615 Refs: nodejs#11720
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I've missed two for loops without initialization in #9615. This adds missing
i = 0to those loops inpunycodeandget-ciphersbenchmarks.Sorry for the trouble.
/cc @mcollina @jasnell
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
benchmarks