src: add HAVE_OPENSSL directive to openssl_config #11618
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Currently when building with the following configuration options: $ ./configure --without-ssl && make The following link error is reported: Undefined symbols for architecture x86_64: "node::openssl_config", referenced from: node::Init(int*, char const**, int*, char const***) in node.o ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) Adding an HAVE_OPENSSL directive around this code allows the build to pass.
nodejs-github-bot added the c++ 
addaleax approved these changes Feb 28, 2017
addaleax added the lib / src 
mscdex added build 
jasnell approved these changes Feb 28, 2017
cjihrig approved these changes Mar 1, 2017
4 tasks
Member
| cc @sam-github |
bnoordhuis approved these changes Mar 1, 2017
2 tasks
sam-github approved these changes Mar 1, 2017
danbev added a commit to danbev/node that referenced this pull request Mar 2, 2017
Currently when building with the following configuration options: $ ./configure --without-ssl && make The following link error is reported: Undefined symbols for architecture x86_64: "node::openssl_config", referenced from: node::Init(int*, char const**, int*, char const***) in node.o ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) Adding an HAVE_OPENSSL directive around this code allows the build to pass. PR-URL: nodejs#11618 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Contributor Author
| Landed in e1d8899 |
Contributor
| This is not landing cleanly on v7.x-staging. Mind opening a backport PR? |
Contributor Author
| Sure thing, give me a day or two. tis 7 mars 2017 kl. 12:53 skrev Evan Lucas <notifications@github.com>: … This is not landing cleanly on v7.x-staging. Mind opening a backport PR? — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#11618 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAaY37tQM-pl0J1JFerwGAbLxJ9FOwYMks5rjUU6gaJpZM4MOynA> . |
2 tasks
danbev added a commit to danbev/node that referenced this pull request Apr 11, 2017
Currently when building with the following configuration options: $ ./configure --without-ssl && make The following link error is reported: Undefined symbols for architecture x86_64: "node::openssl_config", referenced from: node::Init(int*, char const**, int*, char const***) in node.o ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) Adding an HAVE_OPENSSL directive around this code allows the build to pass. PR-URL: nodejs#11618 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
danbev added a commit to danbev/node that referenced this pull request May 30, 2017
Currently when building with the following configuration options: $ ./configure --without-ssl && make The following link error is reported: Undefined symbols for architecture x86_64: "node::openssl_config", referenced from: node::Init(int*, char const**, int*, char const***) in node.o ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) Adding an HAVE_OPENSSL directive around this code allows the build to pass. PR-URL: nodejs#11618 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
3 tasks
Member
| Should this be backported to |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Currently when building with the following configuration options:
$ ./configure --without-ssl && make
The following link error is reported:
Undefined symbols for architecture x86_64:
"node::openssl_config", referenced from:
node::Init(int*, char const**, int*, char const***) in node.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see
invocation)
Adding an HAVE_OPENSSL directive around this code allows the build to
pass.
Checklist
Affected core subsystem(s)
src