Skip to content

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Oct 15, 2019

Blocked by #1921

Ensure that we remain compatible with the newest version of Python.

Checklist
  • npm install && npm test passes
  • tests are included
  • documentation is changed or added
  • commit message follows commit guidelines
Description of change
Copy link
Member

@joaocgreis joaocgreis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cclauss!

@sam-github
Copy link
Contributor

@cclauss the changes looked ok to me, but travis hit

$ pip install flake8 The command "pip install flake8" failed and exited with 127 during . Your build has been stopped. /c/Users/travis/.travis/functions: line 109: pip: command not found 
@cclauss
Copy link
Contributor Author

cclauss commented Oct 16, 2019

Yes. That fix was landed in #1921. Can someone with Travis admin rights please rerun the tests?

Ensure that we remain compatible with the newest version of Python.
@joaocgreis joaocgreis force-pushed the Upgrade-to-Python-3.8 branch from a069872 to 794b6eb Compare October 16, 2019 01:29
@joaocgreis
Copy link
Member

@cclauss I've rebased to make it run. But it looks like there's a lot of backlog in Travis...

Copy link
Member

@rvagg rvagg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 if this passes, it didn't yesterday when I tried but maybe they've released new tarballs for it?

rvagg pushed a commit that referenced this pull request Oct 24, 2019
Ensure that we remain compatible with the newest version of Python. PR-URL: #1923 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@rvagg
Copy link
Member

rvagg commented Oct 24, 2019

landed in b91718e

@rvagg rvagg closed this Oct 24, 2019
@rvagg rvagg deleted the Upgrade-to-Python-3.8 branch October 24, 2019 03:52
rvagg pushed a commit that referenced this pull request Nov 18, 2019
Ensure that we remain compatible with the newest version of Python. PR-URL: #1923 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5 participants