This repository was archived by the owner on Apr 16, 2020. It is now read-only.
esm: cpp refactoring update not to use uv_fs_realpath #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MylesBorins force-pushed the js-realpath branch from c6782f2 to 22b3568 Compare 
Contributor
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
I didn't realise the
uv_fs_realpathis explicitly something to avoid in the previous refactoring, which only came up with the CI error that the windows drive name was being capitalized.This adjusts the previous refactoring to share the package cache without using uv_fs_realpath and sticking to the JS implementation.
@MylesBorins this should squash well into the previous refactoring commit.