Skip to content
This repository was archived by the owner on Apr 16, 2020. It is now read-only.

Conversation

@MylesBorins
Copy link
Contributor

At some point this regressed for extensionless imports
for esm.

At some point this regressed for extensionless imports for esm.
Copy link
Member

@GeoffreyBooth GeoffreyBooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if this is related, but don’t forget that extensionless files are supposed to also look for the "type" field too, not only be executable via --type. The example we’d been discussing was TypeScript’s node_modules/typescript/bin/tsc, which is extensionless and could be written in ESM and executed without --type if node_modules/typescript/package.json contains "type": "module".

@MylesBorins

This comment has been minimized.

@guybedford
Copy link
Contributor

guybedford commented Mar 14, 2019

Yes extensionless support for package.json "type" sounds like a separate bug. Perhaps we can tackle that separately.

Update: Actually it seems this is implemented fine already.

@MylesBorins
Copy link
Contributor Author

Updated, I think it has the correct behavior right now

@MylesBorins
Copy link
Contributor Author

@MylesBorins
Copy link
Contributor Author

failure is unrelated. Will land in 2 hours if there are no objections... necessary for upstreaming

@MylesBorins MylesBorins merged commit 98f4d99 into modules-lkgr Mar 15, 2019
@ljharb ljharb deleted the fix-extensionless branch March 15, 2019 17:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

5 participants