Add sideEffects directive to package.json #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
The sideEffects directive can help module bundlers remove unused imports. By asserting this package doesn't have side effects, it's safe to remove `import "extra-array"` and its contents, if none of the imports are used. Here's an explanatory document in case you aren't familiar. It's in the webpack documentation, but bundlers in general adopt this convention. https://webpack.js.org/guides/tree-shaking/ Thanks for this project, I'll work a lot on arrays, and I like that so many utilities are available in one place!
Member
| Yes, i was not aware of it. Thanks. I should go update this in a few other places. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The sideEffects directive can help module bundlers remove unused imports. By asserting that this package doesn't have side effects, it's safe to remove
import "extra-array/*"and its contents, if none of the imports are used.Here's some docs, in case you aren't familiar. It's in the webpack website, but bundlers in general adopt this convention.
https://webpack.js.org/guides/tree-shaking/
Thanks for this project. I'll work a lot on arrays, and I like that so many utilities are available in one place!