Move some importNodes
logic to external functions #5003
+333 −239
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Proposed changes
Part of #4757.
This first part of the
importNodes
refactoring moves some logic into functions:identifyUnknownTypes
copyConfigNode
copyNode
identifyUnknownTypes
adds a loop in this PR but another one will disappear in the future.I haven't fixed any issues (added todo flag) except in one place: L2469 if the id is updated at this line, the condition at line L2492 will no longer be true. Import copy force
generateIds
to true that's why never detected before. But I wonder if it is not the subflow id that should be used instead of node id.Checklist
npm run test
to verify the unit tests pass