use sha256 for token generation #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
jwerre approved these changes Oct 14, 2021
| I am going to do a special kind of test to make sure this doesn't break an application I currently have. |
| @HappyZombies yes please do, I currently run it against or internal staging app environment to see if the change does raise any issues |
| @jankapunkt looks good, just (as expected) makes the auth code a longer string (and of course) is sha256 ;) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The implements #38 and replaces sha1 with sha256
I also had to update the assertion and all the tests checking for sha256 regex.