Skip to content

Conversation

@sixtus
Copy link

@sixtus sixtus commented Nov 4, 2010

Really helpful and quite cheap.

@felixge
Copy link
Collaborator

felixge commented Nov 4, 2010

I like this idea. What do you think about the following?

  • Create a new form property this.checksum = false
  • checksum can be set to md5, sha1, etc.
  • If crypto is not compiled and checksum is not false, form emits an 'error' event for each upload
  • Add a unit and a system test (if you come around with the above, I'm gonna add the tests for you)

Let me know what you think!

@sixtus
Copy link
Author

sixtus commented Nov 4, 2010

Anything that saves me from rereading the file to compute the checksum is fine with me ;-)

@felixge
Copy link
Collaborator

felixge commented Nov 4, 2010

Yeah, I was mainly asking if you have the time to take this patch a level further. I don't need checksums right now, so I probably won't get to it anytime soon.

@dmmalam
Copy link

dmmalam commented Nov 6, 2011

This would be super useful!

@masterkain
Copy link
Contributor

@felixge
Copy link
Collaborator

felixge commented Jun 4, 2012

Closed by #148.

@felixge felixge closed this Jun 4, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants