Use a WeakMap for private properties #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #42 +/- ## ============================================ + Coverage 86.95% 100.00% +13.04% ============================================ Files 1 1 Lines 69 62 -7 Branches 13 12 -1 ============================================ + Hits 60 62 +2 + Misses 9 0 -9
Continue to review full report at Codecov.
|
| not a WIP anymore, merge? review? (want to work on more stuff after this such as adding offset and blob-part sequence #40) |
Richienb changed the title WeakMap for private properties 
Richienb requested changes Jun 5, 2020
tinovyatkin approved these changes Jun 5, 2020
Richienb approved these changes Jun 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
closes #41