Use upstream Blob directly in typings #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@ ## master #38 +/- ## ======================================= Coverage 86.95% 86.95% ======================================= Files 1 1 Lines 69 69 Branches 13 13 ======================================= Hits 60 60 Misses 9 9 Continue to review full report at Codecov.
|
Closed
| Tests are failing because edit: fixed, amended commit, and pushed |
jimmywarting approved these changes May 20, 2020
Richienb approved these changes May 21, 2020
| Thanks for the quick reviews ❤️ |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Alternative approach to #37
I think that the reason that these were included in the first place was because they weren't present in upstream TypeScript at the time. This have been fixed now with: microsoft/TypeScript#36164
The drawback of this is that we are removing
[Symbol.toStringTag]andtoString. But if we think that it's correct to have them on theBlobI think it would be better to submit patches upstream to add that instead, since the idea behind this package is to bringBlobcross platform.Since we haven't yet published a version with typings this would not be a breaking change!
Closes: #37