Skip to content

fix: misc updates #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 20, 2022
Merged

fix: misc updates #132

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
750c0df
misc updates
jimmywarting Jan 18, 2022
2d9537d
bring back c8 for test coverage
jimmywarting Jan 18, 2022
f874d27
use new loader
jimmywarting Jan 18, 2022
6f2726a
don't use engines
jimmywarting Jan 18, 2022
e6dd803
simplify ci
jimmywarting Jan 18, 2022
36590a4
fix double slice problem
jimmywarting Jan 18, 2022
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bring back c8 for test coverage
  • Loading branch information
@jimmywarting
jimmywarting committed Jan 18, 2022
commit 2d9537dd752a05020e8d8c49ef575506bdaa0cee
3 changes: 1 addition & 2 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ async function * toIterator (parts, clone = true) {
} else {
yield part
}
/* c8 ignore next 10 */
} else {
/* c8 ignore start */
// For blobs that have arrayBuffer but no stream method (nodes buffer.Blob)
let position = 0, b = (/** @type {Blob} */ (part))
while (position !== b.size) {
Expand All @@ -36,7 +36,6 @@ async function * toIterator (parts, clone = true) {
position += buffer.byteLength
yield new Uint8Array(buffer)
}
/* c8 ignore end */
}
}
}
Expand Down
3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
],
"scripts": {
"test": "node --experimental-loader ./test/http-loader.js ./test/test-wpt-in-node.js",
"report": "c8 --reporter json --reporter text npm run test",
"coverage": "npm run report && codecov -f coverage/coverage-final.json",
"prepublishOnly": "tsc --declaration --emitDeclarationOnly --allowJs index.js from.js"
},
"repository": "https://github.com/node-fetch/fetch-blob.git",
Expand All @@ -34,6 +36,7 @@
"homepage": "https://github.com/node-fetch/fetch-blob#readme",
"devDependencies": {
"@types/node": "^17.0.9",
"c8": "^7.11.0",
"typescript": "^4.5.4"
},
"funding": [
Expand Down