Skip to content

fix(from, tests): Fix behavior of BlobDataItem.slice() #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(from, tests): Fix behavior of BlobDataItem.slice() #129

wants to merge 1 commit into from

Conversation

monster860
Copy link

The purpose of this PR is:

To fix the behavior of BlobDataItem.slice() to not break when slicing a slice

This is what had to change:

  • Take into account the existing start position in from.js
  • Added a test

This is what like reviewers to know:

  • I prefixed the PR-title with docs: , fix(area): , feat(area): or breaking(area):
  • I updated ./CHANGELOG.md with a link to this PR or Issue
  • I Added unit test(s)
LinusU
LinusU approved these changes Jan 18, 2022
View reviewed changes
Copy link
Member

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍
@LinusU LinusU requested a review from jimmywarting January 18, 2022 14:23
@jimmywarting
Copy link
Contributor

thanks for pinging me linus, i'm updating the test currently and I'm going to included this change in it.
supperseeded by #132
@jimmywarting jimmywarting mentioned this pull request Jan 18, 2022
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants
@monster860 @jimmywarting @LinusU