fix: use StrEnum

[nirtal85]

Description

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

Summary by CodeRabbit

• New Features

  • Enhanced user type definitions for improved clarity and consistency.

• Bug Fixes

  • Improved handling of session cookie values in tests, ensuring more reliable test behavior.

[coderabbitai]

Walkthrough

The changes involve updating the User enumeration in User.py from using the Enum class to the StrEnum class, allowing enumeration members to have string values that match their names. Additionally, the browser_context_args function in conftest.py was modified to change how session cookie values are assigned, reflecting a new approach in handling request parameters.

Changes

Files	Change Summary
enums/User.py	Changed User class from Enum to StrEnum and updated member assignments to use auto().
tests/conftest.py	Modified browser_context_args function to directly assign request.param to the cookie value.

Poem

🐰 In the code where bunnies play,
Changes hop in a bright new way.
Strings and enums dance in line,
Cookies now sweet, oh so fine!
With every tweak, we cheer and sing,
For better code, let joy take wing! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 2feeca6 and 6068b94.

Files selected for processing (2)

• enums/User.py (1 hunks)
• tests/conftest.py (1 hunks)

Additional comments not posted (2)

enums/User.py (1)

4-8: Approved: Transition to StrEnum with auto().

The transition from Enum to StrEnum enhances type safety and usability. The use of auto() for enumeration values is correctly implemented and simplifies the code by automatically deriving string values from member names.

tests/conftest.py (1)

79-79: Verify the new cookie value assignment.

The change to directly assign request.param to the cookie value simplifies the code. However, it is crucial to verify that request.param contains the correct data format and value expected by the session management system.

Run the following script to verify the correctness of the cookie value assignment:

Verification successful

---

Verification successful: Cookie value assignment is appropriate.

The direct assignment of request.param to the cookie value in the browser_context_args function is consistent with its usage in the test files. The parameterization with user roles suggests that request.param is being used correctly, and the change should not affect the functionality of the session management. No issues were found with this change.

Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash # Description: Verify the correctness of the cookie value assignment. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type python -A 5 $'browser_context_args' 

Length of output: 75

---

Script:

#!/bin/bash # Description: Verify the correctness of the cookie value assignment. # Test: Search for the function usage. Expect: Only occurrences of the new signature. rg --type py -A 5 $'browser_context_args' 

Length of output: 2930