Skip to content

Conversation

@chrisgorgo
Copy link
Member

No description provided.

@chrisgorgo
Copy link
Member Author

intended for maint/0.3 - there is something wrong with github interface again

@satra
Copy link
Member

satra commented Nov 9, 2010

  • this needs another check if jobtype=='write' and isdefined(self.inputs.apply_to_files)
  • _list_outputs needs to be modified

potential thought is to merge source + apply_to_files internally under the write option.

@chrisgorgo
Copy link
Member Author

The question is what should we do if:

  • user inputs source and apply_to_files
  • user inputs only apply_to_files

and whether we should allow this anyway.

@chrisgorgo
Copy link
Member Author

I see two options:

  • when jobtype=="write" disallow using apply_to_files and don't populate coregistered_files output
  • when jobtype=="write" and apply_to_files are set, merge them internally into source but populate outputs to reflect the inputs: source -> coregistered_source, apply_to_files -> coregistered_files
@satra
Copy link
Member

satra commented Nov 10, 2010

i like the latter. i think it lends itself to the same principles and we don't have to craft a inverted trait logic where metadata changes (in principle, not in practice) between instances of traits classes.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants